Skip to content

branch-4.0: [fix](job scheduler) Record task finish time on execution failure #66232 - #66270

Merged
morningman merged 1 commit into
branch-4.0from
auto-pick-66232-branch-4.0
Jul 30, 2026
Merged

branch-4.0: [fix](job scheduler) Record task finish time on execution failure #66232#66270
morningman merged 1 commit into
branch-4.0from
auto-pick-66232-branch-4.0

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Cherry-picked from #66232

…6232)

### What problem does this PR solve?

When a task fails through the execution exception path,
`AbstractTask.runTask()` calls the no-argument `onFail()`, which marked
the task FAILED without recording `finishTimeMs`. MTMV failed refresh
tasks therefore exposed an empty FinishTime and could not calculate
DurationMs.

relate PR:   #27703

### What changes were made?

- Record `finishTimeMs` when `AbstractTask.onFail()` transitions a task
to FAILED.
- Add a regression unit test covering the `runTask()` exception path and
preserving the error message.

### Testing

- `AbstractJobStatusTest`: 13 tests passed.
@github-actions
github-actions Bot requested a review from morningman as a code owner July 30, 2026 07:05
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen

Copy link
Copy Markdown
Contributor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

@hello-stephen

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

@morningman
morningman merged commit 1dbbdee into branch-4.0 Jul 30, 2026
28 of 31 checks passed
@github-actions
github-actions Bot deleted the auto-pick-66232-branch-4.0 branch July 30, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants